[PATCH] D108976: [clang][tooling] Accept custom diagnostic options in ToolInvocation

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 2 11:02:37 PDT 2021


dexonsmith accepted this revision.
dexonsmith added a comment.

In D108976#2979598 <https://reviews.llvm.org/D108976#2979598>, @jansvoboda11 wrote:

> Tests that cover this functionality were moved into a follow-up patch D108974 <https://reviews.llvm.org/D108974>. The reason is to avoid temporary regression pointed out here <https://reviews.llvm.org/D108974#2974782>.

Please document in the commit message that tests are coming later and why. With that, LGTM too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108976/new/

https://reviews.llvm.org/D108976



More information about the cfe-commits mailing list