[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

Alf via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 2 07:46:25 PDT 2021


gAlfonso-bit added a comment.

In D107775#2967134 <https://reviews.llvm.org/D107775#2967134>, @dgoldman wrote:

>> I put a case for it in the declprinter so it is handled appropriately so it would get the pointee type, whereas before this was neglected.
>>
>> Other than that, there should be no difference.
>
> It looks like DeclPrinter only uses that method here <https://github.com/llvm/llvm-project/blob/ef227b32b63c53ca81ebd410c7fbd5af8fc22ec5/clang/lib/AST/DeclPrinter.cpp#L415> - so it shouldn't make a difference.
>
> but TypePrinter does call `isSpecifierType()` so this changes that behavior, right? Can you add a test to TypePrinterTest for this change?

Like for the function itself or an integration test?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107775/new/

https://reviews.llvm.org/D107775



More information about the cfe-commits mailing list