[PATCH] D104344: [modules] Track how headers are included by different modules.

Volodymyr Sapsai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 1 16:28:10 PDT 2021


vsapsai added inline comments.


================
Comment at: clang/lib/Serialization/ASTWriter.cpp:1671
       unsigned KeyLen = key.Filename.size() + 1 + 8 + 8;
-      unsigned DataLen = 1 + 2 + 4 + 4;
+      unsigned DataLen = 1 + 4 + 4 + 4;
+      for (auto ModuleIncluder : Data.HFI.ModuleIncludersMap)
----------------
Note for future readers (including myself). Can save 2 bytes because not writing `Data.HFI.NumIncludes` but need 4 extra bytes for `Data.HFI.ModuleIncludersMap` stop value.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104344/new/

https://reviews.llvm.org/D104344



More information about the cfe-commits mailing list