[PATCH] D108974: [clang][tooling] Properly initialize DiagnosticsEngine for cc1 command-line construction

[Duncan P. N. Exon Smith via Phabricator via cfe-commits]

dexonsmith added inline comments.


================
Comment at: clang/test/ClangScanDeps/strip_diag_serialize.cpp:1-3
+// FIXME: Make this pass again.
+// XFAIL: *
+
----------------
Can you clarify why a temporary regression is necessary? Is there a way of reordering patches to avoid it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108974/new/

https://reviews.llvm.org/D108974