[PATCH] D108085: Use installed llvm-lit.py instead of lit.py PR-51072

Yaron Keren via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 31 08:04:14 PDT 2021


yaron.keren marked an inline comment as done.
yaron.keren added inline comments.


================
Comment at: clang/test/utils/update_cc_test_checks/lit.local.cfg:24
+# Windows: llvm-lit.py, Linux: llvm-lit
+llvm_lit = glob.glob(os.path.join(config.llvm_tools_dir, 'llvm-lit*'))[0]
+lit = config.llvm_external_lit if config.llvm_external_lit else shell_quote(llvm_lit)
----------------
tstellar wrote:
> This patch breaks stand-alone clang builds, because it assumes llvm-lit* will be present in the build directory.   This line should be guarded by if not config.llvm_external_lit.
Continued in https://reviews.llvm.org/D109000


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108085/new/

https://reviews.llvm.org/D108085



More information about the cfe-commits mailing list