[PATCH] D108982: [clang][deps] Avoid creating diagnostic serialization file, add test

[Duncan P. N. Exon Smith via Phabricator via cfe-commits]

dexonsmith requested changes to this revision.
dexonsmith added a comment.
This revision now requires changes to proceed.

Code changes LGTM, just a comment on the test.



================
Comment at: clang/test/ClangScanDeps/diagnostics.c:8
+
+// CHECK-NOT: error: invalid iOS deployment version
----------------
Should this just be:
```
CHECK-NOT: error:
```
?


Also, is there a positive CHECK or two you could add? And possibly a comment to explain what the test is for? (It's not obvious to me from the name "diagnostics".)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108982/new/

https://reviews.llvm.org/D108982