[PATCH] D108979: [clang][deps] NFC: Stop going through ClangTool

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 31 07:46:58 PDT 2021


dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.

LGTM. I've independently been wondering for a while whether ClangTool was doing more harm than good for the scanning usecase.

I'm approving as-is, since this is a step forward, but I'm curious if you can clarify what ToolInvocation is providing, and whether that's worth it or if it'd make sense (eventually) to go a step further.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108979/new/

https://reviews.llvm.org/D108979



More information about the cfe-commits mailing list