[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

[John McCall via Phabricator via cfe-commits]

rjmccall added a comment.

Well, I'm saying two things.  First, it is not clear to me what the expected behavior of that code is under the standard.  The fact that it appears to work in one particular implementation is not in any way conclusive; we have to look at the specification.  Second, I think it only appears to work: looking at the runtime code in both libc++abi and libsupc++, it leaks the memory of the exception object, which it's clearly not allowed to do.   You should be able to fairly easy prove that by looking at heap usage if you do it in a loop.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108905/new/

https://reviews.llvm.org/D108905