[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 30 06:43:37 PDT 2021


erichkeane added a comment.

In D93769#2972203 <https://reviews.llvm.org/D93769#2972203>, @erichkeane wrote:

> In D93769#2972151 <https://reviews.llvm.org/D93769#2972151>, @matthewtff wrote:
>
>>> It looks like Melanie asked the questions but it wasn't resolved.
>>
>> Can this CL be reverted and relanded later with a fix? This breakage is crucial for a lot of remote/distributed compilation systems.
>
> Did someone perhaps fix this in trunk?  I don't see it on godbolt: https://godbolt.org/z/r76rx5Evd
>
> See the preprocessed version ends up being:
>
> int main() {
>
>   std::cout << "Hello, " "One" << std::endl;
>
> }

Ah, nvm, I see what I did wrong.  The test requires 32 bit to fail, since there is an `#elif` branch of the `#ifdef __FLT_EVAL_METHOD__`.   Disregard.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93769/new/

https://reviews.llvm.org/D93769



More information about the cfe-commits mailing list