[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

[Björn Schäpers via Phabricator via cfe-commits]

HazardyKnusperkeks added inline comments.


================
Comment at: clang/docs/tools/dump_format_style.py:23
+  plurals = {
+    'IncludeCategory': 'IncludeCategories'
+  }
----------------
FederAndInk wrote:
> HazardyKnusperkeks wrote:
> > Could you not just check if there is a y at the end and replace it with ies, otherweise add an s?
> Well, I thought about it, but then what about: whish -> whishes, leaf -> leaves, ... and irregulars? That's why I brought up the idea about using python inflect. Do you think it's enough for now to replace y -> ies and put an 's' to the others?
I'm okay with either way, in both cases there comes a time where someone must pay attention to add something here. We just have to look carefully in the review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108765/new/

https://reviews.llvm.org/D108765