[PATCH] D102943: [modules] Use `HashBuilder` and `MD5` for the module hash.

Alexandre Rames via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 27 16:28:45 PDT 2021


arames marked 3 inline comments as done.
arames added inline comments.


================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4580
 
-  return llvm::APInt(64, code).toString(36, /*Signed=*/false);
+  return llvm::APInt(64, Hash.getValue()).toString(36, /*Signed=*/false);
 }
----------------
dexonsmith wrote:
> Do we just want 64 bits, or do we want the full hash?
My guess is either would be fine. I thought combining the two parts was simple enough.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102943/new/

https://reviews.llvm.org/D102943



More information about the cfe-commits mailing list