[PATCH] D102449: [WIP][Clang][OpenMP] Add the support for compare clause in atomic directive

Shilei Tian via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 27 15:43:18 PDT 2021


tianshilei1992 updated this revision to Diff 369208.
tianshilei1992 added a comment.

1. Ignore implicit cast in some cases.
2. Add the test case.

What are still missing:

1. Code generation for floating point types.

Question:

1. What atomic instruction(s) should we use for floating point types? Current I can see we do support floating point types for `update` clause, but the emitted code doesn't look like atomic operations.
2. When do we have to use `IgnoreParenImpCasts`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102449/new/

https://reviews.llvm.org/D102449

Files:
  clang/include/clang/AST/OpenMPClause.h
  clang/include/clang/AST/RecursiveASTVisitor.h
  clang/include/clang/AST/StmtOpenMP.h
  clang/include/clang/Basic/DiagnosticSemaKinds.td
  clang/include/clang/Sema/Sema.h
  clang/lib/AST/OpenMPClause.cpp
  clang/lib/AST/StmtOpenMP.cpp
  clang/lib/AST/StmtProfile.cpp
  clang/lib/Basic/OpenMPKinds.cpp
  clang/lib/CodeGen/CGStmtOpenMP.cpp
  clang/lib/Parse/ParseOpenMP.cpp
  clang/lib/Sema/SemaOpenMP.cpp
  clang/lib/Sema/TreeTransform.h
  clang/lib/Serialization/ASTReader.cpp
  clang/lib/Serialization/ASTWriter.cpp
  clang/test/OpenMP/atomic_compare_codegen.cpp
  clang/tools/libclang/CIndex.cpp
  llvm/include/llvm/Frontend/OpenMP/OMP.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102449.369208.patch
Type: text/x-patch
Size: 48982 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210827/f07c9fb0/attachment-0001.bin>


More information about the cfe-commits mailing list