[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 27 12:21:46 PDT 2021


rjmccall added a comment.

Thanks, style suggestion aside, this looks great.  Would you mind doing the TypeInfo change in a separate patch?  The functional change for AIX can be a really small improvement on top of that.



================
Comment at: clang/include/clang/AST/ASTContext.h:167
 
+enum class AlignRequirementType {
+  /// The alignment was not explicit in code.
----------------
We've been calling things like this `FooKind` for a while.  `FooType` is pretty problematic in a compiler where we have a lot of type representations.  I think there are a few grandfathered exceptions, but still, let's call it `AlignRequirementKind`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107394/new/

https://reviews.llvm.org/D107394



More information about the cfe-commits mailing list