[PATCH] D108832: [Builtins] Support ext_vector_type args for __builtin_fminf.

Florian Hahn via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 27 10:28:47 PDT 2021


fhahn updated this revision to Diff 369135.
fhahn added a comment.

Updated to remove stray comment.

In D108832#2969512 <https://reviews.llvm.org/D108832#2969512>, @erichkeane wrote:

> I think I would want some level of examination/analysis as to whether we want to do this with all of the vector-types, instead of just the `ext_vector_type`.

I think we should extend this to all vector types and matrix types. I only went with ext_vector_types to keep things simple initially to make sure the direction is acceptable first.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108832/new/

https://reviews.llvm.org/D108832

Files:
  clang/include/clang/Basic/Builtins.def
  clang/include/clang/Sema/Sema.h
  clang/lib/Sema/SemaChecking.cpp
  clang/test/CodeGen/overloaded-math-builtins.c
  clang/test/Sema/overloaded-math-builtins.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108832.369135.patch
Type: text/x-patch
Size: 5296 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210827/42f7c618/attachment.bin>


More information about the cfe-commits mailing list