[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 27 06:27:43 PDT 2021


MyDeveloperDay added a comment.

In D108765#2969036 <https://reviews.llvm.org/D108765#2969036>, @FederAndInk wrote:

> For now, I handle plural manually, but it can be changed, I also kept Unsigned, what are your thoughts?



  I think thats ok for now, did you try building the file with sphinx-build, I run
  
  `/usr/bin/sphinx-build -n ./docs ./html`
  
  Then go and look at the html

> Thanks for being so kind and responsive, it's really great to work on that :) as it is my first contribution to clang.



  That is how it should be right ;-).
  
  I assume you don't have commit access, we'll need your name and email address if you want one of us to land it, so we can accredit you with the contribution, but if you think you might like to work on some other things, it might be worth get ting the  "getting commit access" process started.
  
  I think its always good to wait to give others some chance to comment before we commit, as we are all in different timezones.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108765/new/

https://reviews.llvm.org/D108765



More information about the cfe-commits mailing list