[PATCH] D108810: [clang-format] [PR51640] - New AfterEnum brace wrapping changes have cause C# behaviour to change

Owen Pan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 27 06:20:02 PDT 2021


owenpan added a comment.

LGTM.



================
Comment at: clang/lib/Format/TokenAnnotator.cpp:3799
+    if (Style.BraceWrapping.AfterEnum) {
+      if (Line.startsWith(tok::kw_enum) ||
+          Line.startsWith(tok::kw_typedef, tok::kw_enum))
----------------
Nit: I think it would be a little more efficient to call `FirstNonComment->is` instead.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108810/new/

https://reviews.llvm.org/D108810



More information about the cfe-commits mailing list