[PATCH] D108752: [clang-format] Group options that pack constructor initializers

Owen Pan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 27 03:57:11 PDT 2021


owenpan added a comment.

In D108752#2967040 <https://reviews.llvm.org/D108752#2967040>, @MyDeveloperDay wrote:

> This looks good, I like to move towards one style, it was getting too confusing.

I agree!

> Did you test this on a large code base at all?

No. I don't think it's necessary (as this patch doesn't impact breaking constructor initializers except perhaps for the new value `Never`, which is already covered by the new test cases) but will try.

> I'll pull the patch to my local source and see if it makes any changes, but to be honest we only use the `BreakConstructorInitializersBeforeComma` option

Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108752/new/

https://reviews.llvm.org/D108752



More information about the cfe-commits mailing list