[PATCH] D108752: [clang-format] Group options that pack constructor initializers

Owen Pan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 27 02:00:39 PDT 2021


owenpan added inline comments.


================
Comment at: clang/unittests/Format/FormatTest.cpp:18472
+              FormatStyle::PCIS_Never);
+
   Style.EmptyLineBeforeAccessModifier = FormatStyle::ELBAMS_LogicalBlock;
----------------
HazardyKnusperkeks wrote:
> Should there be a test for the mapping?
Ideally yes, but `CHECK_PARSE` can't check mappings of multiple to one, e.g.:
```
  CHECK_PARSE("ConstructorInitializerAllOnOneLineOrOnePerLine: true\n"
              "AllowAllConstructorInitializersOnNextLine: false",
              PackConstructorInitializers, FormatStyle::PCIS_CurrentLine);
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108752/new/

https://reviews.llvm.org/D108752



More information about the cfe-commits mailing list