[PATCH] D108794: Fully qualify template template parameters when printing

[David Blaikie via Phabricator via cfe-commits]

dblaikie created this revision.
dblaikie added reviewers: aaron.ballman, rtrieu.
Herald added a subscriber: arphaman.
dblaikie requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

I discovered this quirk when working on some DWARF - AST printing prints
type template parameters fully qualified, but printed template template
parameters the way they were written syntactically, or wholely
unqualified - instead, we should print them consistently with the way we
print type template parameters: fully qualified.

The one place this got weird was for partial specializations like in
ast-print-temp-class.cpp - hence the need for checking for
TemplateNameDependenceScope::DependentInstantiation template template
parameters. (not 100% sure that's the right solution to that, though -
open to ideas)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D108794

Files:
  clang/include/clang/AST/TemplateName.h
  clang/lib/AST/NestedNameSpecifier.cpp
  clang/lib/AST/TemplateBase.cpp
  clang/lib/AST/TemplateName.cpp
  clang/lib/CodeGen/CGDebugInfo.cpp
  clang/test/CXX/drs/dr10xx.cpp
  clang/test/CXX/temp/temp.fct.spec/temp.deduct/temp.deduct.type/p9-0x.cpp
  clang/test/Index/print-type.cpp
  clang/test/Misc/diag-template.cpp
  clang/test/SemaTemplate/temp_arg_template.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108794.369009.patch
Type: text/x-patch
Size: 9652 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210827/e083cae3/attachment.bin>