[PATCH] D102449: [WIP][Clang][OpenMP] Add the support for compare clause in atomic directive

[Carlo Bertolli via Phabricator via cfe-commits]

carlo.bertolli added a comment.

Thanks for uploading this.

I tried it locally and it is missing proper parsing +sema of the cond-expr-stmt and cond-update-stmt as indicate in the openmp 5.1 spec's. I am sure you are aware of this and this is still WIP.
Do you plan to add support for that? The regression test is not exposing conditional statements, but update ones, so it is not really testing what it should.

You might also want to split parse+sema support from codegen, if it helps.

Many thanks again!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102449/new/

https://reviews.llvm.org/D102449