[PATCH] D107769: [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins

[Anastasia Stulova via Phabricator via cfe-commits]

Anastasia added a comment.

In D107769#2960441 <https://reviews.llvm.org/D107769#2960441>, @svenvh wrote:

> I have done an alternative spin of this patch: instead of introducing `RequireDisabledExtension`, simply always make the `private`, `global`, and `local` overloads available.  This makes tablegen diverge from `opencl-c.h` though.  Perhaps we should also always add make the `private`, `global`, and `local` overloads available in `opencl-c.h`?

Yes, we could do this indeed as a clang extension. I don't think this will impact the user code. However, this means vendors will have to add extra overloads in OpenCL 2.0 mode?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107769/new/

https://reviews.llvm.org/D107769