[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

Thu Aug 26 08:22:55 PDT 2021

masoud.ataei marked an inline comment as done.
masoud.ataei added a comment.

In D101759#2967250 <https://reviews.llvm.org/D101759#2967250>, @lebedev.ri wrote:

> Do we *really* need `-enable-approx-func-fp-math`?
> I'm pretty sure we are moving away from such global options, onto relying only on the per-instruction fast-math flags.

I am handling LLVM intrinsic math functions in PPCISelLowering.cpp, so I need to check for `TM.Options.ApproxFuncFPMath`. This is the only place that I think I need it. 
Currently, I am updating `TM.Options.ApproxFuncFPMath` in `llvm/lib/CodeGen/CommandFlags.cpp` using the global option. Please let me know if there is a better way to update `TM.Options.ApproxFuncFPMath` based on the local fast-math flag.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101759/new/

https://reviews.llvm.org/D101759