[PATCH] D106191: [clang] Option control afn flag

Thu Aug 26 07:30:37 PDT 2021

masoud.ataei added a comment.

In D106191#2966852 <https://reviews.llvm.org/D106191#2966852>, @qiucf wrote:

> Making a new option mapped to another float op flag looks reasonable, but is there any clearer motivation for this? (such as the need for `-Ofast -fno-approx-func`)

This patch https://reviews.llvm.org/D101759 is the real motivation for option controlling afn flag. We want to have a way to distinguishes getting `_finite` or `non-finite` version of MASS functions. Only with afn flag (on O3 <https://reviews.llvm.org/owners/package/3/>), we want to get `non-finite` version of MASS functions. (finite version need extra fast-math flags.)

================
Comment at: llvm/include/llvm/Target/TargetOptions.h:179
+    /// with approximate calculations
+    unsigned ApproxFuncFPMath : 1;
+
----------------
qiucf wrote:
> `-enable-no-signed-zeros-fp-math` is an `llc` flag.
> 
> Do we really have `-enable-approx-func-fp-math` for `llc` now?
I am adding and using this option in https://reviews.llvm.org/D101759 patch. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106191/new/

https://reviews.llvm.org/D106191