[PATCH] D105462: [X86] Add CRC32 feature.

Wang Tianqing via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 25 20:04:23 PDT 2021


tianqing marked an inline comment as done.
tianqing added inline comments.


================
Comment at: clang/lib/Basic/Targets/X86.cpp:160
+  // enabled.
+  I = Features.find("sse4.2");
+  if (I != Features.end() && I->getValue() &&
----------------
craig.topper wrote:
> I guess I don't understand why this is coded differently than mmx, popcnt, and xsave?
Well, I just found they're functionally equivalent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105462/new/

https://reviews.llvm.org/D105462



More information about the cfe-commits mailing list