[PATCH] D108268: [Modules] Change result of reading AST block to llvm::Error instead

[Ben Barham via Phabricator via cfe-commits]

bnbarham updated this revision to Diff 368781.
bnbarham added a comment.

Ended up just using DiagnosticError and reading the args from PartialDiagnostic. Still not really happy with this, but I think the alternative of allowing multiple in-flight diagnostics should be a separate PR regardless (if done at all).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108268/new/

https://reviews.llvm.org/D108268

Files:
  clang/include/clang/Serialization/ASTReader.h
  clang/lib/Serialization/ASTReader.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108268.368781.patch
Type: text/x-patch
Size: 34071 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210826/b39d13cf/attachment-0001.bin>