[PATCH] D108661: The maximal representable alignment in LLVM IR is 1GiB, not 512MiB

[Matt Arsenault via Phabricator via cfe-commits]

arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/X86/load-with-1gb-alignment.mir:1
+# RUN: llc -run-pass machine-cp -o - %s | FileCheck %s
+
----------------
Should use -run-pass=none, and go in test/CodeGen/MIR/X86


================
Comment at: llvm/test/CodeGen/X86/load-with-1gb-alignment.mir:6-16
+--- |
+  ; ModuleID = '/tmp/test.ll'
+  source_filename = "/tmp/test.ll"
+  target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
+
+  define i32 @load(i32* %ptr) {
+    %r = load i32, i32* %ptr, align 1073741824
----------------
Don't need the IR section


================
Comment at: llvm/test/CodeGen/X86/load-with-1gb-alignment.mir:31
+
+    renamable $eax = MOV32rm killed renamable $rdi, 1, $noreg, 0, $noreg :: (load (s32) from %ir.ptr, align 1073741824)
+    RETQ $eax
----------------
Don't need the IR reference, can also test basealign


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108661/new/

https://reviews.llvm.org/D108661