[PATCH] D105462: [X86] Add CRC32 feature.

[Pengfei Wang via Phabricator via cfe-commits]

pengfei added inline comments.


================
Comment at: llvm/lib/Support/X86TargetParser.cpp:531
 constexpr FeatureBitset ImpliedFeaturesSSSE3 = FeatureSSE3;
 constexpr FeatureBitset ImpliedFeaturesSSE4_1 = FeatureSSSE3;
 constexpr FeatureBitset ImpliedFeaturesSSE4_2 = FeatureSSE4_1;
----------------
hjl.tools wrote:
> pengfei wrote:
> > Can we let `ImpliedFeaturesSSE4_1 = FeatureSSSE3 | FeaturesCRC32` so that we don't need to add `crc32` on sse4.1 and above?
> SSE4.1 implies CRC32.  But CRC32 shouldn't imply SSE4.1.
Yes. The constexpr here means `FeaturesSSE4_1` implies both `FeatureSSSE3` and `FeaturesCRC32`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105462/new/

https://reviews.llvm.org/D105462