[PATCH] D108302: [PowerPC] Fixed the crash due to early if conversion with fixed CR fields.

Lei Huang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 25 06:22:02 PDT 2021


lei requested changes to this revision.
lei added a comment.
This revision now requires changes to proceed.

I think there is something wrong with this diff cause there is no context available for `PPCInstrInfo.cpp`.



================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.cpp:1548
+    return false;
+  }
+
----------------
nit: no need for braces 


================
Comment at: llvm/test/CodeGen/PowerPC/ifcvt_cr_field.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -mtriple=powerpc64-unknown-linux-gnu -mcpu=pwr7 -verify-machineinstrs | FileCheck %s
+target datalayout = "E-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-f128:128:128-v128:128:128-n32:64"
----------------
I believe this affects AIX as well.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108302/new/

https://reviews.llvm.org/D108302



More information about the cfe-commits mailing list