[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

[Alexey Bader via Phabricator via cfe-commits]

bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: clang/lib/Basic/Targets/SPIR.h:146
+    // See comment on the SPIRDefIsGenMap table.
+    bool IsHIPSPV = Opts.HIP && Opts.CUDAIsDevice;
     // FIXME: SYCL specification considers unannotated pointers and references
----------------
Minor: in my opinion, Opts.HIP check is unnecessary. I don't think CUDA can be compiled to SPIR target today, but when this flow is enabled I think it should set `DefaultIsGeneric` flag the same way as HIP.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108621/new/

https://reviews.llvm.org/D108621