[PATCH] D108680: PR48030: Fix COMDAT-related linking problem with C++ thread_local static data members.

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 24 19:05:13 PDT 2021


rsmith added a comment.

Note that there's a potential ABI impact here: because we accidentally put the `__cxx_global_init` function into a COMDAT with the variable, that meant that the `_ZTH` symbol (which is an alias to `__cxx_global_init`) also pointed into that same COMDAT. I'm not sure how much that matters given that the old behavior was broken.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108680/new/

https://reviews.llvm.org/D108680



More information about the cfe-commits mailing list