[PATCH] D107685: [WebAssembly] Tidy up EH/SjLj options
Heejin Ahn via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 23 16:33:06 PDT 2021
aheejin added inline comments.
================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:449
+ // done in WasmEHPrepare pass after these IR passes, but Wasm SjLj requires
+ // Emscripten libraries and processed together in LowerEmscriptenEHSjLJ pass.
+ if (WasmEnableEmEH || WasmEnableEmSjLj || WasmEnableSjLj)
----------------
dschuff wrote:
> it's not clear what "and processed" is intended to mean here.
Yeah the sentence is unclear and even grammatically incorrect... Rewrote it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107685/new/
https://reviews.llvm.org/D107685
More information about the cfe-commits
mailing list