[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

[Tiago Macarios via Phabricator via cfe-commits]

tiagoma added a comment.

In D54943#2959546 <https://reviews.llvm.org/D54943#2959546>, @JonasToth wrote:

> thanks for your testing! i will look at the `__unaligned` issue, not sure if clang supports it, its an MSVC extension, is it?

Yes it is. The clang frontend supports it. I am not sure about the backend.

> Did the transformations produce issues and approximately how much code did you check? I would like to get a better feeling for its quality before enabling it by default.

I run it in all of Microsoft Word. It seems pretty solid to me. The places where it breaks it is due to the code being ill-formed in some way (which is a welcome break). I already have to tell tidy to apply the fixits, so I am not sure what having the extra flag adds. I would suggest have them on by default and letting people disable it if they need.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54943/new/

https://reviews.llvm.org/D54943