[PATCH] D102449: [WIP][Clang][OpenMP] Add the support for compare clause in atomic directive

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 23 08:42:45 PDT 2021


jdoerfert added a comment.

Is this still WIP or should it be reviewed? Needs a proper commit message.



================
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5797-5800
+  // Cannot emit atomic operation.
+  // TODO: Do we really want to emit a non-atomic operation here?
+  if (!Res.first) {
+  }
----------------
This looks like something is missing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102449/new/

https://reviews.llvm.org/D102449



More information about the cfe-commits mailing list