[PATCH] D108456: [CUDA] Fix static device variables with -fgpu-rdc

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 20 10:38:31 PDT 2021


tra added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6450
     llvm::raw_ostream &OS) const {
-  OS << ".static." << getContext().getCUIDHash();
+  OS << "__static__" << getContext().getCUIDHash();
 }
----------------
I would expect  NVPTXAssignValidGlobalNames.cpp to deal with this ptx quirk. 
I'm fine with the underscores, but it would be good we're not just covering up an issue somewhere else.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108456/new/

https://reviews.llvm.org/D108456



More information about the cfe-commits mailing list