[PATCH] D108469: Improve handling of static assert messages.

Corentin Jabot via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 20 09:53:43 PDT 2021


cor3ntin added inline comments.


================
Comment at: clang/lib/Basic/Diagnostic.cpp:818
+      llvm::raw_string_ostream stream(number);
+      stream << "<U+" << llvm::format_hex_no_prefix(c, 4, true) << ">";
+      OutStr.append(number.begin(), number.end());
----------------
jfb wrote:
> We don't have a better hex formatter? 😟
> Not a big deal, but I'd hoped that ADT had something!
There are a few hex formatter, none that pads to a minimum size!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108469/new/

https://reviews.llvm.org/D108469



More information about the cfe-commits mailing list