[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data
Jozef Lawrynowicz via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Aug 20 09:15:02 PDT 2021
jozefl updated this revision to Diff 367805.
jozefl added a comment.
Here's an updated patch to fix the win64 failure.
MSVC can't handle the conversion from a ForwardIterator to a const pointer when
the container being searched with std::lower_bound is a std::array. Meanwhile
clang-tidy warns when the type assigned to with the return value of
std::lower_bound is not a pointer, so I can't just change the type declaration
to a lone "auto", and surpressing the clang-tidy warning for this warning
doesn't seem like the best option either.
So I've changed the data type used to store the MCUData to a C-style array, and
also moved its definition into loadMCUData.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108301/new/
https://reviews.llvm.org/D108301
Files:
clang/include/clang/Basic/MSP430Target.def
clang/lib/Driver/ToolChains/MSP430.cpp
clang/test/Driver/msp430-hwmult.c
clang/test/Driver/msp430-mmcu.c
clang/test/Driver/msp430-toolchain.c
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108301.367805.patch
Type: text/x-patch
Size: 52493 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210820/ced7b87e/attachment-0001.bin>
More information about the cfe-commits
mailing list