[PATCH] D108464: [clang][CodeGen] Refactor CreateTempAlloca function nest. NFC.
Andy Wingo via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Aug 20 06:04:28 PDT 2021
wingo added a comment.
Sooooo... besides the refactor, this is getting closer to where I'm going in https://lists.llvm.org/pipermail/cfe-dev/2021-July/068559.html, though still NFC. I think you can see where I would replace `getASTAllocaAddressSpace` with `getAllocaAddressSpace(QualType Ty)`, and possibly (depending on the source language) avoid casting the resulting alloca to `LangAS::Default`. WDYT, is this sort of thing OK?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108464/new/
https://reviews.llvm.org/D108464
More information about the cfe-commits
mailing list