[PATCH] D108421: Mark openmp internal global dso_local

[Alexey Bataev via Phabricator via cfe-commits]

ABataev added inline comments.


================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2182-2189
+  llvm::GlobalVariable *GV = new llvm::GlobalVariable(
+      CGM.getModule(), Ty, /*IsConstant*/ false,
+      llvm::GlobalValue::CommonLinkage, llvm::Constant::getNullValue(Ty),
+      Elem.first(), /*InsertBefore=*/nullptr, llvm::GlobalValue::NotThreadLocal,
+      AddressSpace);
+  GV->setDSOLocal(true);
+  Elem.second = GV;
----------------
I would not do it here since the linkage is changing in some places. Better to make this kind of change explicitly where required + need to add tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108421/new/

https://reviews.llvm.org/D108421