[PATCH] D106804: [test-suite] Add tests for FP classification intrinsics
Simon Pilgrim via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Aug 20 01:56:46 PDT 2021
RKSimon added a comment.
Something I noticed is that we don't have much test coverage in clang/test/codegen for the fpclass intrinsics - including no constexpr testing afaict (although I don't think __builtin_fpclassify is constexpr yet) - is that something you'd be willing to take a look at?
================
Comment at: SingleSource/UnitTests/Float/classify.cpp:89
+ assert(!__builtin_isnormal(*FPtr));
+ assert(__builtin_fpclassify(0, 1, 2, 3, 4, *FPtr) == 0);
+ }
----------------
are asserts the best way to do this? most other unit tests print out something to help isolate diffs
Repository:
rT test-suite
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106804/new/
https://reviews.llvm.org/D106804
More information about the cfe-commits
mailing list