[PATCH] D107690: [Modules] Do not remove failed modules after the control block phase

Yaron Keren via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 19 10:31:02 PDT 2021


yaron.keren added inline comments.


================
Comment at: clang/lib/Serialization/ASTReader.cpp:4268
     // Read the AST block.
     if (ASTReadResult Result = ReadASTBlock(F, ClientLoadCapabilities))
+      return Failure;
----------------
vsapsai wrote:
> yaron.keren wrote:
> > Result is unused now.
> Thanks for pointing it out. Are there any bots failing because of that now? Asking if should have a small urgent fix or if can wait for https://reviews.llvm.org/D108268 to land.
Just a compiler warning, could wait.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107690/new/

https://reviews.llvm.org/D107690



More information about the cfe-commits mailing list