[PATCH] D107690: [Modules] Do not remove failed modules after the control block phase

[Yaron Keren via Phabricator via cfe-commits]

yaron.keren added inline comments.


================
Comment at: clang/lib/Serialization/ASTReader.cpp:4268
     // Read the AST block.
     if (ASTReadResult Result = ReadASTBlock(F, ClientLoadCapabilities))
+      return Failure;
----------------
Result is unused now.


================
Comment at: clang/lib/Serialization/ASTReader.cpp:4279
     while (!SkipCursorToBlock(F.Stream, EXTENSION_BLOCK_ID)) {
       if (ASTReadResult Result = ReadExtensionBlock(F))
+        return Failure;
----------------
Same here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107690/new/

https://reviews.llvm.org/D107690