[PATCH] D107850: [asan] Implemented custom calling convention similar to the one used by HWASan for X86.

[Kirill Stoimenov via Phabricator via cfe-commits]

kstoimenov marked 7 inline comments as done.
kstoimenov added a comment.

Added getAddressSanitizerParams to pull the constants out. Let me know if this is what you had in mind. Also struggled a little bit with git and rebase, but I think I have figured it out now.



================
Comment at: llvm/lib/Target/X86/X86MCInstLower.cpp:1340-1341
+  MCSymbol *&Sym = AsanMemaccessSymbols[{
+      Reg, ShadowBase, IsWrite, AccessSizeIndex, MI.getOperand(4).getImm(),
+      MI.getOperand(5).getImm()}];
+  if (!Sym) {
----------------
vitalybuka wrote:
> vitalybuka wrote:
> > Why shadow is an argument? Both runtime and instrumented code know the shadow.
> could you please unpack these to into local variables for consistency?
Removed the variables as we have discussed. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107850/new/

https://reviews.llvm.org/D107850