[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute
Alexander Potapenko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Aug 19 07:01:16 PDT 2021
glider added a comment.
In D108029#2954566 <https://reviews.llvm.org/D108029#2954566>, @melver wrote:
> llvm/docs/LangRef.rst also needs a corresponding change.
Right, will do. I thought LangRef was missing the sanitizer bits as well, and was planning to add them together, but apparently I was just looking for the wrong attributes.
================
Comment at: llvm/lib/AsmParser/LLLexer.cpp:646
KEYWORD(dereferenceable_or_null);
+ KEYWORD(disable_sanitizer_instrumentation);
KEYWORD(elementtype);
----------------
melver wrote:
> Do the tests pass?
>
> There should also be the code that actually turns the token into the attribute in llvm/lib/AsmParser/LLParser.cpp
check-llvm and check-clang pass for me, check-all seems to choke on some unrelated bugs.
LLParser is using Tablegen now, no need to change it: https://github.com/llvm/llvm-project/blob/main/llvm/lib/AsmParser/LLParser.cpp#L1247
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108029/new/
https://reviews.llvm.org/D108029
More information about the cfe-commits
mailing list