[PATCH] D108021: [dllexport] Instantiate default ctor default args

[Peter Jiachen via Phabricator via cfe-commits]

peterjc123 added a comment.

Sure, please do that.



================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:6012
+        auto *CD = dyn_cast<CXXConstructorDecl>(MD);
+        if (CD && CD->isDefaultConstructor() && TSK == TSK_Undeclared) {
+          S.InstantiateDefaultCtorDefaultArgs(CD);
----------------
rnk wrote:
> This should probably happen when explicit instantiation definitions are exported, so the `TSK_ExplicitInstantiationDefinition` case. However, I don't consider it a blocking issue.
Well, I cannot constuct one code example that includes explicit instantiation definitions which triggers this problem. If you could provide one, then I may look into it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108021/new/

https://reviews.llvm.org/D108021