[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 18 10:26:11 PDT 2021


tra added inline comments.


================
Comment at: clang/test/Driver/cuda-version-check.cu:75
 
-// UNKNOWN_VERSION_V: unknown CUDA version: version.txt:{{.*}}; assuming the latest supported version
-// UNKNOWN_VERSION_H: unknown CUDA version: cuda.h: CUDA_VERSION={{.*}}; assuming the latest supported version
-// UNKNOWN_VERSION: unknown CUDA version: no version found in version.txt or cuda.h; assuming the latest supported version
+// UNKNOWN_VERSION: CUDA version [unknown] is newer than the latest{{.*}} supported version
+// NEW_VERSION: CUDA version 99010 is newer than the latest{{.*}} supported version
----------------
Hahnfeld wrote:
> Can we keep the `[unknown]` out of the warning message? I understand that we cannot nicely print a version identifier that we don't know about, so maybe only print if the version is known and newer than `PARTIALLY_SUPPORTED`?
Done. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108247/new/

https://reviews.llvm.org/D108247



More information about the cfe-commits mailing list