[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

Vyacheslav Zakharin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 18 08:07:04 PDT 2021


vzakhari added a comment.

In D99551#2952336 <https://reviews.llvm.org/D99551#2952336>, @JonChesterfield wrote:

> Nvptx broken here too, amdgpu is fine. I'm guessing one of the cuda tools does some overly aggressive input validation that we're running afoul of.
>
> There was a discussion about this on the call today - plan was to put it behind a disabled boolean argument while fixing to avoid downstream churn. Sadly the original patch was not authored with that in mind. I suggest if we can't get that patch together asap we revert this and fix it offline (even if the fix is adding said flag)

I am about to merge D108246 <https://reviews.llvm.org/D108246> that is adding the switch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99551/new/

https://reviews.llvm.org/D99551



More information about the cfe-commits mailing list