[PATCH] D108243: Revert "Avoid needlessly copying a block to the heap when a block literal"

James Y Knight via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 17 14:30:26 PDT 2021


jyknight created this revision.
jyknight added reviewers: ahatanak, erik.pilkington, rjmccall.
jyknight requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

It has been reverted in Apple's Clang fork for quite some time,
possibly ever since it was submitted upstream. No useful purpose is
served by having the semantics of blocks -- which are an Apple
extension in the first place -- diverge between Apple's compiler and
upstream clang.

This reverts commit c5792aa90fa45a1842f190c146f19e2c71ea6fbd.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D108243

Files:
  clang/include/clang/AST/Decl.h
  clang/include/clang/AST/DeclBase.h
  clang/lib/AST/Decl.cpp
  clang/lib/CodeGen/CGObjC.cpp
  clang/lib/Sema/SemaDecl.cpp
  clang/lib/Sema/SemaExpr.cpp
  clang/lib/Serialization/ASTReaderDecl.cpp
  clang/lib/Serialization/ASTWriterDecl.cpp
  clang/test/CodeGenObjC/arc-block-copy-escape.m
  clang/test/CodeGenObjC/arc-blocks.m
  clang/test/CodeGenObjCXX/arc-blocks.mm
  clang/test/PCH/arc-blocks.mm

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108243.367016.patch
Type: text/x-patch
Size: 17170 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210817/676c2607/attachment-0001.bin>


More information about the cfe-commits mailing list