[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common
Brian Cain via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 17 14:27:16 PDT 2021
bcain added inline comments.
================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_syscall_linux_hexagon.inc:88
+{
+ register long r6 __asm__("r6") = n;
+ register long r0 __asm__("r0") = a;
----------------
vitalybuka wrote:
> should this use u64 like other __internal_syscall files?
Sorry I didn't notice this review comment before.
No, `u64` doesn't seem appropriate - they're 32-bit registers. I can change it to `u32` if that makes more sense.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108083/new/
https://reviews.llvm.org/D108083
More information about the cfe-commits
mailing list