[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

Tue Aug 17 14:24:07 PDT 2021

vzakhari added a comment.

In D99551#2950522 <https://reviews.llvm.org/D99551#2950522>, @jhuber6 wrote:

> In D99551#2950515 <https://reviews.llvm.org/D99551#2950515>, @vzakhari wrote:
>
>> In D99551#2950464 <https://reviews.llvm.org/D99551#2950464>, @jhuber6 wrote:
>>
>>> In D99551#2950281 <https://reviews.llvm.org/D99551#2950281>, @vzakhari wrote:
>>>
>>>> @jhuber6, thank you for reporting this.  I do not have a properly setup CUDA system currently.  Can you please invoke `clang-offload-wrapper` with `-save-temps` and send the temporary files to me <vyacheslav.p.zakharin at intel.com>?
>>>
>>> I sent it to you, any luck or should we revert this upstream for the time being.
>>
>> Unfortunately, I did not receive it.  Can you please check if the mail was blocked on your side?  Can you please try to archive it with a password and send it again?
>> I would like to prepare a patch to put this functionality under a switch that is off by default.  I think we want to have this working eventually (and it actually works with x86_64 offload), so it will be easier to just flip a switch, when I figure out what CUDA API does not like about the modified ELF image.  Does it sound appropriate to you?
>
> I put it in a .tar.gz file, I think your domain is blocking it. Anything else I can use?

Can you please try sharing it via Google drive?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99551/new/

https://reviews.llvm.org/D99551