[PATCH] D108083: [sanitizer] Add hexagon support to sanitizer-common

[Vitaly Buka via Phabricator via cfe-commits]

vitalybuka added a comment.

In D108083#2949934 <https://reviews.llvm.org/D108083#2949934>, @bcain wrote:

> In D108083#2949815 <https://reviews.llvm.org/D108083#2949815>, @vitalybuka wrote:
>
>>> We can help create a bot for hexagon-unknown-linux-musl. What's the process?
>>
>> Thank you. https://llvm.org/docs/HowToAddABuilder.html
>
> Oh I think I misunderstood:
>
>> Volunteers can provide their build machines to work as build workers to public LLVM Buildbot.
>
> I was prepared to write / test / enable a build recipe but I don't have access to a public system that can be added as a worker.  But I can work with our team to get the ball rolling, it just doesn't seem like it would be a quick process.

Please try to do so. Even infrequent builds, like one per day, are helpful. Without that implementation will likely degrade overtime.



================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_stacktrace.cpp:25
   return pc + 8;
-#elif defined(__powerpc__) || defined(__arm__) || defined(__aarch64__)
+#elif defined(__powerpc__) || defined(__arm__) || defined(__aarch64__) \
+  || defined(__hexagon__)
----------------
bcain wrote:
> bcain wrote:
> > vitalybuka wrote:
> > > but please fix ones like this which do not require significant reformatting of unchanged code.
> > Ok that's no problem.
> >> but please fix ones like this which do not require significant reformatting of unchanged code.
> > Ok that's no problem.
> 
> But it's a little odd -- following the format would pull the `or` operator onto the previous line, which would deviate from the style used in the rest of the file.
> 
> Still happy to make the change, it just doesn't seem like it fits.
Goal is to avoid manual labor as much as possible even if clang-format result are a little bit inconsistent.
I guess code around was added before we started using clang-format.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108083/new/

https://reviews.llvm.org/D108083